search

mbof / hxsync

Program Standard Horizon marine radios (HX870, HX890, HX891BT, and GX1400) from any computer using your browser
https://mbof.github.io/hx/
MIT License
4 stars 1 forks source link

Occasionally incorrect padding for MMSI names #59

Closed mbof closed 4 months ago

mbof commented 4 months ago

1) Based on a DAT file, it looks like the padding for MMSI is not always generated as expected. Occasionally the last byte of the name is not FF. I'm not sure if this is something that hxsync emits.

2) When the padding is incomplete, the name is presented incorrectly - padding characters are presented as part of the name. The name should stop at the first padding character encountered instead of being included in the name.

mbof commented 4 months ago

Here was one way to reproduce this. 1) Write a directory containing entries with 16-character names (it turns out, only 15 characters are supported). 2) Rename one of the entries on the device in a way that reorders entries

-> some of the 16th characters were left around in lieu of padding.

The first part of the fix was to only write names up to 15 characters. The second part of the fix was to not misbehave when names had incomplete padding.