search

mbogh / NibDesignable

Elegant way of enabling IBDesignable on your nib-based views
MIT License
342 stars 74 forks source link

Change setupNib #31

Closed farzadshbfn closed 8 years ago

farzadshbfn commented 8 years ago

This way we'll remove the extra UIView as holder of our nib, and overhead will be decreased in views loaded, specially in cells.

farzadshbfn commented 8 years ago

When used in CollectionViewCells or TableViewCells, if there are two NibDesignable views in design, in runtime there are actually 4 (and if badly used, 5) views which has huge performance impact. this way, number of views is the same number of views developers injected into storyboard. (or more if they added some in code ;) )

farzadshbfn commented 8 years ago

I don't know what's wrong with the test, gets stuck at the final phase and just TLE. I recommend you to take a look at my code ;)

farzadshbfn commented 8 years ago

@mbogh Do you know what's wrong with my pull request? this commit might cause problems due to changing view's hierarchical, but my other pull request just adds support for UITableViewHeaderFooterView, and that pull request failed Travis CI build too.

farzadshbfn commented 8 years ago

This PL does not support Backward-Compatibility.