search

mbogh / NibDesignable

Elegant way of enabling IBDesignable on your nib-based views
MIT License
342 stars 74 forks source link

support for Swift3 with Xcode8GM #42

Closed sstadelman closed 7 years ago

sstadelman commented 7 years ago

This updates the syntax for Swift3, with Xcode-beta6 language updates.

The target Use Legacy Swift Language Version build setting is set to NO.

Validated in internal development for ~2 weeks.

esetnik commented 7 years ago

@sstadelman have you seen any issues like:

9/8/16 12:23:28.546 PM Xcode[39414]: [MT] IBSceneUpdate: [scene update, delegate=<IBStoryboardDocument: 0x7fcc65d9ce00>] Error Domain=com.apple.InterfaceBuilder Code=-1 "Failed to load designables from path /Users/xxx/Library/Developer/Xcode/DerivedData/xxx-chwnxjxzdxmxfqdzqibbbsciffle/Build/Intermediates/IBDesignables/Products/Debug-iphonesimulator/NibDesignable/NibDesignable.framework" UserInfo={NSUnderlyingError=0x7fcc68c319a0 {Error Domain=com.apple.InterfaceBuilder Code=-1 "dlopen(NibDesignable.framework, 1): Symbol not found: __TMps13OptionSetType
  Referenced from: NibDesignable.framework
  Expected in: /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/Library/Xcode/Overlays/../../../../../../Toolchains/XcodeDefault.xctoolchain/usr/lib/swift/iphonesimulator/libswiftCore.dylib
 in NibDesignable.framework" UserInfo={NSLocalizedDescription=dlopen(NibDesignable.framework, 1): Symbol not found: __TMps13OptionSetType
  Referenced from: NibDesignable.framework
  Expected in: /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/Library/Xcode/Overlays/../../../../../../Toolchains/XcodeDefault.xctoolchain/usr/lib/swift/iphonesimulator/libswiftCore.dylib
 in NibDesignable.framework}}, NSLocalizedFailureReason=dlopen(NibDesignable.framework, 1): Symbol not found: __TMps13OptionSetType
  Referenced from: NibDesignable.framework
  Expected in: /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/Library/Xcode/Overlays/../../../../../../Toolchains/XcodeDefault.xctoolchain/usr/lib/swift/iphonesimulator/libswiftCore.dylib
 in NibDesignable.framework, NSLocalizedDescription=Failed to load designables from path /Users/xxx/Library/Developer/Xcode/DerivedData/xxx-chwnxjxzdxmxfqdzqibbbsciffle/Build/Intermediates/IBDesignables/Products/Debug-iphonesimulator/NibDesignable/NibDesignable.framework}
sstadelman commented 7 years ago

@esetnik no, I haven't seen that... is your framework search path set correctly?

esetnik commented 7 years ago

@sstadelman are you using Cocoapods or carthage to manage your NibDesignable dependency?

esetnik commented 7 years ago

@mbogh can you rerun the travis tests? They failed with a strange error and the tests pass locally.

ikesyo commented 7 years ago

Using xcodebuild build-for-testing test-without-building should stabilize the CI builds on Travis with Xcode 8.

esetnik commented 7 years ago

@mbogh can we get this merged?

mbogh commented 7 years ago

If we could get Travis happy again, I am all for this PR :)

esetnik commented 7 years ago

@mbogh the tests are actually passing it's just that travis was flakey when @sstadelman uploaded his build. You can see a recent passed test run using the same commit at https://travis-ci.org/esetnik/NibDesignable/jobs/160884386. Please rerun the tests on travis and they should pass this time.

ikesyo commented 7 years ago

@esetnik See my comment above for the test failure: https://github.com/mbogh/NibDesignable/pull/42#issuecomment-246109828

mbogh commented 7 years ago

Travis build has been restart lets see what the verdict is :)

mbogh commented 7 years ago

@farzadshbfn do you have any objections?

farzadshbfn commented 7 years ago

@mbogh no, I had objections against other PR's. this one's so clean 👍