mbogh / fastlane-plugin-teams

MIT License
48 stars 15 forks source link

teams action fails with succeed message #11

Open flashspys opened 1 year ago

flashspys commented 1 year ago
~/DEV/**** nightly ❯ fastlane run teams                                                                                                                                                                                                 13:37:21
[✔] 🚀 
+-----------------------+---------+-----------+
|                Used plugins                 |
+-----------------------+---------+-----------+
| Plugin                | Version | Action    |
+-----------------------+---------+-----------+
| fastlane-plugin-badge | 1.5.0   | add_badge |
| fastlane-plugin-teams | 0.2.0   | teams     |
+-----------------------+---------+-----------+

[13:37:26]: -------------------
[13:37:26]: --- Step: teams ---
[13:37:26]: -------------------
[13:37:26]: To not be asked about this value, you can specify it using 'title'
[13:37:26]: The title that should be displayed on Teams: Test
[13:37:30]: To not be asked about this value, you can specify it using 'message'
[13:37:30]: The message that should be displayed on Teams. This supports the standard Teams markup language: Hallo
[13:37:35]: To not be asked about this value, you can specify it using 'facts'
[13:37:35]: Optional facts: 
[13:37:36]: To not be asked about this value, you can specify it using 'teams_url'
[13:37:36]: Create an Incoming WebHook for your Teams channel: **************************************************************************************************************************************************************************************************************

[!] An error occurred: {"version":"1.1","content":{"headers":[{"key":"Content-Type","value":["text/plain; charset=utf-8"]}]},"statusCode":200,"reasonPhrase":"OK","headers":[],"trailingHeaders":[],"requestMessage":null,"isSuccessStatusCode":true}

As seen above currently the teams action fails. The error message only shows success messages and the teams message also is delivered successfully. My guess is, that the check_response_code function is not up to date.

Kaiming-Lee commented 1 year ago

Got the same problem in our CICD system while using this Fastlane plugin to call Teams webhook

[13:23:46]: An error occurred: {"version":"1.1","content":{"headers":[{"key":"Content-Type","value":["text/plain; charset=utf-8"]}]},"statusCode":200,"reasonPhrase":"OK","headers":[],"trailingHeaders":[],"requestMessage":null,"isSuccessStatusCode":true} +------+----------------------------+-------------+ | fastlane summary | +------+----------------------------+-------------+ | Step | Action | Time (in s) | +------+----------------------------+-------------+ | 1 | default_platform | 0 | | 2 | changelog_from_git_commits | 0 | | 💥 | teams | 3 | +------+----------------------------+-------------+ [13:23:46]: fastlane finished with errors [!] An error occurred: {"version":"1.1","content":{"headers":[{"key":"Content-Type","value":["text/plain; charset=utf-8"]}]},"statusCode":200,"reasonPhrase":"OK","headers":[],"trailingHeaders":[],"requestMessage":null,"isSuccessStatusCode":true} Cleaning up project directory and file based variables 00:00 ERROR: Job failed: exit status 1