d3.min.js - keep as reference or local file

mbojan / d3net

Shiny application for interactive network data visualization and exploration

7 stars 2 forks source link

d3.min.js - keep as reference or local file #15

Closed pawluczuk closed 10 years ago

pawluczuk commented 10 years ago

Two options to choose:

include d3 library as reference (http://d3js.org/d3.v3.min.js) - working slower, but package is lighter
include d3 library files locally - the package would be heavier, but working without internet connection and faster

mbojan commented 10 years ago

Ideally we could do both and leave the choice to the user... but that's difficult at this moment.

The library has 150kb. That's nothing. Let's add it locally to exec subdirectory. As suggested here http://cran.r-project.org/doc/manuals/r-release/R-exts.html#Non_002dR-scripts-in-packages

pawluczuk commented 10 years ago

Shiny apps require all additional files (js/css) to be kept in the application folder, so it seems that exec subdirectory is not available. Additionally, library is ~150kb, but it's needed in both applications, so it adds extra ~300kb in this case. Though, in my opinion it's still better to keep it that way, so that the package is not reliant on internet connection.

mbojan commented 10 years ago

Sounds good