search

mbok / logsniffer

logsniffer is a sophisticated open source web tool for parsing, viewing, monitoring and analyzing log data - smarter, collaborative and easier. [No longer maintaned]
GNU Lesser General Public License v3.0
104 stars 47 forks source link

adding travis ci #76

Closed chriseverty closed 8 years ago

chriseverty commented 8 years ago

I have set-up a working travis-ci job for the project. In the go I have noticed and removed two warnings that have been reported in the log.

In order to get the build running I needed to increase the width of the column entry_id in table QRTZ_FIRED_TRIGGERS ([1], [2]). It would not build on the travis-ci VMs otherwise. Those seem to have a very long machine name, which appears to be used as part of the generated key.

In order to get it working for the main project these steps would be required

One thing I noted is that there is one really long running test: CompoundLogReaderTest#testLongComposition. It takes 10 of the 14 minutes build time. I assume that this is some sort of benchmark? Probably this one could be put into an according jUnit category so that it maybe excluded from CI builds.

mbok commented 8 years ago

Wow, great job, thanks a lot! I'll merge the pull request in few days as soon I'm back from holidays.

logsniffer commented 8 years ago

@chriseverty May I ask you to to sign logsniffer's Contributor License Agreement and to send it please to cla@logsniffer.com? This is only required once, no matter how many contributions you make in the future. Thank you for helping with this unfortunate administrative requirement.

chriseverty commented 8 years ago

Hello Micheal,

please find the signed CLA attached. By the way I am a native German speaker. But I think discussions on Github should be kept in English, shouldn't they? :)

On Fri, Jun 24, 2016 at 11:57 PM, logsniffer notifications@github.com wrote:

@chriseverty https://github.com/chriseverty May I ask you to to sign logsniffer's Contributor License Agreement http://www.logsniffer.com/wp-content/uploads/2016/06/cla.pdf and to send it please to cla@logsniffer.com? This is only required once, no matter how many contributions you make in the future. Thank you for helping with this unfortunate administrative requirement.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/logsniffer/logsniffer/pull/76#issuecomment-228471945, or mute the thread https://github.com/notifications/unsubscribe/AAg5Z6ucwgR2ndwrfAFH58hwUOy-UxxTks5qPFKtgaJpZM4IyZld .

logsniffer commented 8 years ago

Hi @chriseverty,

leider ist der Anhang nicht durchgekommen :-( Ich denke, es wird von GitHub bei Benutzung der Mailantwortfunktion nicht unterstützt. Könntest du es bitte nochmal an cla@logsniffer.com schicken. Danke für die Mühe!

And now I switch better again to English :-)