mbolli / nfsen-ng

Responsive NetFlow visualizer built on top of nfdump tools.
Apache License 2.0
232 stars 44 forks source link

Added missing nfdump column names #59

Closed jp-asdf closed 4 years ago

jp-asdf commented 4 years ago

Added missing nfdump column names to the nfdump_translation var and render_table function to fix a bug where some Statistics reports output was broken (missing half of the data when using order-by other then "Flows").

Bug: When running any of the "IP address" Statistics reports AND using any "Order by" method other than "Flows", half of the report output is missing. All data after the "Flows (%)" column is missing. When using"Order by = Flows" the report output is good and all columns are displayed correctly.

Cause: It appears that the nfdump csv output has different column names when using "-s ip/flows" report compared to when running a "-s ip/bytes" or other order-by method. Some of these column names are not defined in nfsen-ng/frontend/js/nfsen-ng.js in the "nfdump_translation" var.

NFDUMP columns returned when using -s 'ip/flows' ts,te,td,pr,val,fl,flP,ipkt,ipktP,ibyt,ibytP,ipps,ibps,ibpp

NFDUMP columns returned when using -s 'ip/bytes' ts,te,td,pr,val,fl,flP,pkt,pktP,byt,bytP,pps,bps,bpp

Fix: Add the missing fields "pktP" and "bytP" to the "nfdump_translation" var in nfsen-ng.js.

mbolli commented 4 years ago

great addition, thanks!