search

mbologna / docker-bitlbee

Run bitlbee with TLS and custom protocols in a container
MIT License
45 stars 25 forks source link

Bump bitlbee-facebook to receive bugfixes #9

Closed raidancampbell closed 3 years ago

raidancampbell commented 3 years ago

See discussion here: https://github.com/bitlbee/bitlbee-facebook/issues/200

mbologna commented 3 years ago

The cleanup part is missing the fix: https://github.com/mbologna/docker-bitlbee/pull/9/files#diff-4d2a8eefdf2a9783512a35da4dc7676a66404b6f3826a8af9aad038722da6823R128

Can you please take care of updating it?

raidancampbell commented 3 years ago

D'oh! absolutely.

raidancampbell commented 3 years ago

Alrighty, it'll be a bit. I ran build.sh on my mac development laptop to test, and left it in the background to churn. Turns out it ran through the filesystem and rm -rf'd a rather large chunk by the time I got to it.

raidancampbell commented 3 years ago

I didn't have a BITLBEE_VERSION env variable set, so the script ultimately cd'd me to ~, tried and failed a bunch of stuff, then tried to cleanup. https://github.com/mbologna/docker-bitlbee/blob/master/build.sh#L9

This sucks, I'll try and get you the fix eventually, but it's fairly low on my priorities now.

raidancampbell commented 3 years ago

resolved via 235a1b4d6cc73434738524cda1440826deec4aed

mbologna commented 3 years ago

I didn't have a BITLBEE_VERSION env variable set, so the script ultimately cd'd me to ~, tried and failed a bunch of stuff, then tried to cleanup. https://github.com/mbologna/docker-bitlbee/blob/master/build.sh#L9

This sucks, I'll try and get you the fix eventually, but it's fairly low on my priorities now.

That's bad, sorry. Weren't you running the docker build in a container?!

mbologna commented 3 years ago

resolved via 235a1b4d6cc73434738524cda1440826deec4aed

Confirmed. Thanks for taking care of this bump!

raidancampbell commented 3 years ago

I didn't have a BITLBEE_VERSION env variable set, so the script ultimately cd'd me to ~, tried and failed a bunch of stuff, then tried to cleanup. https://github.com/mbologna/docker-bitlbee/blob/master/build.sh#L9 This sucks, I'll try and get you the fix eventually, but it's fairly low on my priorities now.

That's bad, sorry. Weren't you running the docker build in a container?!

I thought I'd be 100% sure the build worked correctly, so I ran build.sh without reading it. I didn't know at the time that it was meant to be executed within docker.

Lessons learned, etc...