search

mborgerding / kissfft

a Fast Fourier Transform (FFT) library that tries to Keep it Simple, Stupid
Other
1.39k stars 278 forks source link

Modernize upstream package after inclusion to Debian #57

Closed basilgello closed 3 years ago

basilgello commented 3 years ago

Hi @mborgerding !

As a maintainer of Kodi from Debian I packaged kissfft-float into Debian. It is going to be included in next Debian stable (bullseye).

I had to expose fftnd, fftndr, fftr as part of public API because nearly all programs that required kissfft as build dependency used that headers. This has already been proposed in #39 but the relevant PR is still open.

Can you please review and incorporate my PR if that aligns with your vision of the project?

Vasyl

mborgerding commented 3 years ago

The changes look pretty good as far as I can tell. caveat: my cmake fluency is pretty weak.

re PR #39: Apologies to @jtojnar -- I let the ball drop on that PR. Is there be any benefit or harm to merging that as well as this PR?

basilgello commented 3 years ago

re PR #39: Apologies to @jtojnar -- I let the ball drop on that PR. Is there be any benefit or harm to merging that as well as this PR

Let me update Makefile too, starting from his commit.

basilgello commented 3 years ago

just so I understand ... kiss_fftr.c is no longer required here because it is incorporated above, right?

Yes. We create a library and link executable against it.