search

mborgerson / pyside6_qtads

Python bindings to Qt Advanced Docking System for PySide6
Other
21 stars 8 forks source link

Bindings prototype differences do not fail compilation #9

Open mborgerson opened 1 year ago

mborgerson commented 1 year ago

After 4.0.0 upgrade:

2023-02-16T00:33:10.8022257Z   (bindings) [3662ms] Checking inconsistencies in function modifications...       qt.shiboken: (bindings) D:\a\pyside6_qtads\pyside6_qtads\src\bindings.xml:124: signature 'addDockWidget(ads::DockWidgetArea,ads::CDockWidget*,ads::CDockAreaWidget*)' (specified as 'addDockWidget(ads::DockWidgetArea, ads::CDockWidget*, ads::CDockAreaWidget*)') for function modification in 'ads::CDockContainerWidget' not found.
2023-02-16T00:33:10.8023270Z     Possible candidates:
2023-02-16T00:33:10.8023824Z       addDockWidget(ads::DockWidgetArea,ads::CDockWidget*,ads::CDockAreaWidget*,int) in CDockContainerWidget
2023-02-16T00:33:10.8025407Z 
2023-02-16T00:33:10.8026764Z   qt.shiboken: (bindings) D:\a\pyside6_qtads\pyside6_qtads\src\bindings.xml:176: signature 'addDockWidget(ads::DockWidgetArea,ads::CDockWidget*,ads::CDockAreaWidget*)' (specified as 'addDockWidget(ads::DockWidgetArea, ads::CDockWidget*, ads::CDockAreaWidget*)') for function modification in 'ads::CDockManager' not found.
2023-02-16T00:33:10.8027809Z     Possible candidates:
2023-02-16T00:33:10.8028959Z       addDockWidget(ads::DockWidgetArea,ads::CDockWidget*,ads::CDockAreaWidget*,int) in CDockManager
2023-02-16T00:33:10.8029499Z 
2023-02-16T00:33:10.8030674Z   qt.shiboken: (bindings) D:\a\pyside6_qtads\pyside6_qtads\src\bindings.xml:176: signature 'addDockWidgetTabToArea(ads::CDockWidget*,ads::CDockAreaWidget*)' (specified as 'addDockWidgetTabToArea(ads::CDockWidget*, ads::CDockAreaWidget*)') for function modification in 'ads::CDockManager' not found.
2023-02-16T00:33:10.8031802Z     Possible candidates:
2023-02-16T00:33:10.8032302Z       addDockWidgetTabToArea(ads::CDockWidget*,ads::CDockAreaWidget*,int) in CDockManager
2023-02-16T00:33:10.8032705Z 
2023-02-16T00:33:10.8033078Z   [WARNING]

This should have failed the build process, but did not for some reason, and was missed during release.

This particular instance is the apparent root cause of https://github.com/githubuser0xFFFF/Qt-Advanced-Docking-System/issues/494

n-elie commented 1 year ago

It seems to be the standard behavior of shiboken to only write a warning in logs I don't see any option to generate an error instead of a warning. It would probably be necessary to parse the logs after the bindings are generated