mboskamp / MMM-PIR

This MagicMirror module monitors a PIR sensor and turns on/off your display. You can even run custom scripts and control it via Telegram.
16 stars 6 forks source link

MMM-PIR showCountdown: false, interacts with another module #7

Open Kugelfang666 opened 5 years ago

Kugelfang666 commented 5 years ago

Kugelfang 11 minutes ago

Dear all,

I currently use two modules in my setup which for some unknown reason are cross-interacting in a unwanted way:

My config.js looks like this:

    {
        module: 'MMM-PIR',
        position: 'bottom_center',
        config: {
            sensorPin: 4,
            delay: 30000,
            turnOffDisplay: true,
            showCountdown: true,
            callbackScripts: ["callback.py"]
        }
    },

    {
      module: "MMM-AVStock",
      header: "Stocks",
      position: "top_right", //"bottom_bar" is better for `mode:ticker`
      config: {
        apiKey : "XXXXXXXXXX", // https://www.alphavantage.co/
        timeFormat: "DD-MM-YYYY HH:mm:ss",
        symbols : ["aapl", "GOOGL", "AMZN"],
        alias: ["Apple", "Google", "Amazon"], 
        tickerDuration: 60, 
        chartDays: 90,
        poolInterval : 1000*15, 
        mode : "table", // "table", "ticker", "series"
        decimals: 2, 
        candleSticks : false, 
        coloredCandles : false, 
        premiumAccount: false, 
      }
    },

Now comes the peculiar thing: if I set

showCountdown: false, in MMM-PIR the on screen countdown of this module disappears as intended but so does also the list of the AVStock. In fact the header of AVStocks is still there but the actual list does not appear. Also if I change the

mode : "table", // "table", "ticker", "series"

nothing happens. This behavior is fully reversible and reproducible. It would be great if someone could help me out on this.

mboskamp commented 5 years ago

Hi @Kugelfang666, thanks for raising the issue and thanks to https://github.com/eouia/MMM-AVStock/issues/7#issuecomment-480493963 for finding the cause. Feel free to raise a pull request. I am happy to merge it. I'm not sure when I will find the time to push the changes myself. Cheers