mbostock / gistup

Create a gist from terminal, then use git to update it.
Other
488 stars 41 forks source link

instructions missing something #24

Open brianally opened 9 years ago

brianally commented 9 years ago

Sorry, wasn't sure what to title this. Not super important.

When you press any key to continue, your web browser will open. Please login (if needed) and fill out the resulting form to create an access token. When you’re done, copy the access token to the clipboard and paste it back into the terminal.

[msg about pressing any key etc]

The msg above, which i can't recall exactly, will change to "Enter personal access token:" only after one closes their browser. Otherwise, it seems as if gistup has hung up. Once i clued in and closed the browser everything was fine. I thought that part should be made clear.

Thanks a bunch for the cool tool. And every other one you've created.

mbostock commented 9 years ago

Hmm. I think this is operating system dependent, unfortunately. On OS X, the open command returns immediately after opening the specified URL in your default browser. On Linux, perhaps the xdg-open command behaves differently? I expect the code could be changed to not wait until the command completes and instead have it run in the background.

brianally commented 9 years ago

Sorry, i meant to specify this was on linux. I just had a look around and found this discussion about the same issue, which closely approximates my initial assumptions. I opened the issue only to suggest that the instructions mention that the browser may need to be closed to continue. Something like,

if(process.platform === "linux") {
    console.log("You may need to close the browser afterwards to continue.");
}
CrandellWS commented 9 years ago

not able to reproduce this though this is related https://github.com/CrandellWS/gistup/commit/54e6c687455507d23986743810f45ff1c88cdcda

hdon commented 7 years ago

I didn't have quite the problem OP had, but I can agree that this dialog caught me off guard for a moment :)

sukrosono commented 4 years ago

Sry if this is not the right place, I just quickly read.

Here my problem, it possible due to my network is unreliable.

image

and here what the "black cat" says:

Selection_045

and this still happen, even after I regenerated the token image