search

mbostock / shapefile

A cross-platform streaming parser for the ESRI Shapefile spatial data format.
Other
790 stars 153 forks source link

Can’t fetch URLs that don’t have .shp/.dbf extensions. #63

Open mbostock opened 4 years ago

mbostock commented 4 years ago

Testing for .shp or .dbf at the end isn’t a good test for URLs. For example, it means you can’t pass a URL to an Observable FileAttachment (because those never have the .shp extension, and adding the .shp extension breaks the URL).

I think we should probably get rid of this magic. It might be okay to replace .shp with .dbf if the dbf argument is undefined, but otherwise I think we should leave the URLs as-is.

polkerty commented 4 years ago

Second this motion

chadRoberge commented 4 years ago

Not that it needs a third but....Third this motion.