Non-portable use of python-config

[GoogleCodeExporter]

pywebkitgtk-1.1.5 determines the -I flags for python via:

dnl check for python
AM_PATH_PYTHON(2.4)
AM_CHECK_PYTHON_HEADERS(,[AC_MSG_ERROR(could not find Python headers)])
AC_MSG_CHECKING([for pythons include path])
PYTHON_INCLUDES=`python-config --includes`
AC_MSG_RESULT($PYTHON_INCLUDES)

Three bugs in the last two lines:
1. AM_PATH_PYTHON and the rest of the python autotools bits allow using a
$PYTHON env var to declare a specific python interp to use (arbitrary name
and location), but `python-config` ignores that. Means the -I flags might
not be correct for the python used elsewhere. Should use `${PYTHON}-config`
instead for consistency.
2. python-config is only available as of python2.5, but package claims to
work with python2.4. That suggests using python2.4 won't get the -I flags
for python, which is a build problem.
3. This whole exlpicit hand-coded PYTHON_INCLUDES setting is not needed at
all, since the earlier AM python macros handle it automatically.

Original issue reported on code.google.com by dma...@gmail.com on 19 Jun 2009 at 10:10

[GoogleCodeExporter]

Hi! I've committed a patch to remove the manual override of PYTHON_INCLUDES in 
r137.
You're right, it's unnecessary. Let me know if that fixes this issue.

Thanks!

Original comment by jmalo...@gmail.com on 20 Jun 2009 at 2:17

• Changed state: Accepted

[GoogleCodeExporter]

Works for me. That fix is part of fink's patchset.

Original comment by dma...@gmail.com on 22 Jun 2009 at 8:13

[GoogleCodeExporter]

Original comment by jmalo...@gmail.com on 23 Jun 2009 at 12:43

• Changed state: Verified