mboudreau / Alternator

A mock DynamoDB that runs locally for testing purposes - DEPRECATED, PLEASE USE DYNAMODB LOCAL: https://docs.aws.amazon.com/amazondynamodb/latest/developerguide/DynamoDBLocal.html
Apache License 2.0
78 stars 39 forks source link

UpdateItem with version attribute not working #76

Closed miclefebvre closed 11 years ago

miclefebvre commented 11 years ago

updateItem only verified if the expectedAttribute was null or empty when the item wasn't in the database. But the java client add version: valueExists=False when the version field is used.

Now if expectedAttribute s not empty, it validates that it contains only valueExists=false for all fields..

Refactor to use validatedExpected() everywhere instead of doing the same code again and again.

mboudreau commented 11 years ago

Awesome. Thanks for the commit.

miclefebvre commented 11 years ago

You're welcome. Thanks for the really useful project.

Do you plan to make any release soon, because I really need the fix in my project ?

Thank you

mboudreau commented 11 years ago

Sure thing. I'll get it done tomorrow if you don't mind.

In the meantime, you can still "mvn install" it locally with your new changes and use it in your project as a dependency.

On Thu, Sep 12, 2013 at 10:30 PM, miclefebvre notifications@github.comwrote:

You're welcome. Thanks for the really useful project.

Do you plan to make any release soon, because I really need the fix in my project ?

Thank you

— Reply to this email directly or view it on GitHubhttps://github.com/mboudreau/Alternator/pull/76#issuecomment-24314360 .

"If at first you don't succeed, use a bigger hammer." - Unofficial motto of the Royal Electrical and Mechanical Engineers

miclefebvre commented 11 years ago

Yes, thank you it is already installed locally but we are more than one on the project.

Thank you very much. On Sep 12, 2013 7:35 PM, "Michel Boudreau" notifications@github.com wrote:

Sure thing. I'll get it done tomorrow if you don't mind.

In the meantime, you can still "mvn install" it locally with your new changes and use it in your project as a dependency.

On Thu, Sep 12, 2013 at 10:30 PM, miclefebvre notifications@github.comwrote:

You're welcome. Thanks for the really useful project.

Do you plan to make any release soon, because I really need the fix in my project ?

Thank you

— Reply to this email directly or view it on GitHub< https://github.com/mboudreau/Alternator/pull/76#issuecomment-24314360> .

"If at first you don't succeed, use a bigger hammer." - Unofficial motto of the Royal Electrical and Mechanical Engineers

— Reply to this email directly or view it on GitHubhttps://github.com/mboudreau/Alternator/pull/76#issuecomment-24363859 .

miclefebvre commented 11 years ago

I don't mind to wait a couple of days On Sep 12, 2013 7:42 PM, "Michael Lefebvre" miclefebvre@gmail.com wrote:

Yes, thank you it is already installed locally but we are more than one on the project.

Thank you very much. On Sep 12, 2013 7:35 PM, "Michel Boudreau" notifications@github.com wrote:

Sure thing. I'll get it done tomorrow if you don't mind.

In the meantime, you can still "mvn install" it locally with your new changes and use it in your project as a dependency.

On Thu, Sep 12, 2013 at 10:30 PM, miclefebvre notifications@github.comwrote:

You're welcome. Thanks for the really useful project.

Do you plan to make any release soon, because I really need the fix in my project ?

Thank you

— Reply to this email directly or view it on GitHub< https://github.com/mboudreau/Alternator/pull/76#issuecomment-24314360> .

"If at first you don't succeed, use a bigger hammer." - Unofficial motto of the Royal Electrical and Mechanical Engineers

— Reply to this email directly or view it on GitHubhttps://github.com/mboudreau/Alternator/pull/76#issuecomment-24363859 .

mboudreau commented 11 years ago

Alright, your changes has been pushed to version 0.6.5.

Thanks for contributing!

miclefebvre commented 11 years ago

Perfect tanx On Sep 14, 2013 6:31 AM, "Michel Boudreau" notifications@github.com wrote:

Alright, your changes has been pushed to version 0.6.5.

Thanks for contributing!

— Reply to this email directly or view it on GitHubhttps://github.com/mboudreau/Alternator/pull/76#issuecomment-24442622 .