Bootstrap 4 support

[jeevcat]

Is there an easy way to switch over to Bootstrap 4, while using this extension? I understand it's still in Alpha, but I figured it might be something other people might also be interested in.

[mbr]

Unfortunately, I am a bit strapped for time and haven't had a look at Bootstrap 4 yet - I'm waiting for it to be released first. Your best option is a fork to try it out.

Usually changing version numbers is straightforward, you'll have to find out yourself how backwards-incompatible the whole thing really is =).

On Thu, Jun 29, 2017 at 8:06 PM, Sam Jeeves notifications@github.com wrote:

Is there an easy way to switch over to Bootstrap 4, while using this extension? I understand it's still in Alpha, but I figured it might be something other people might also be interested in.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/mbr/flask-bootstrap/issues/162, or mute the thread https://github.com/notifications/unsubscribe-auth/AAGv8cCb5-eQC2ZhpDU8-ZUet4BVZM01ks5sI-ebgaJpZM4OJq_Y .

[jeevcat]

Okay thanks for the reply.

I've forked the repo and managed to get v4.0.0-Alpha.6 working. I had to include Tether.js which is required by Bootstrap 4 for tooltips apparently. I also had to fiddle a little with the versioning regex due to the -alpha-style version numbers.

[cofinley]

@jeevcat If you have something that works, I'd love to check it out on your fork once you push it.

[jeevcat]

I actually already pushed it 2 days ago. Check it out here: https://github.com/jeevcat/flask-bootstrap-4-alpha.

Please let me know if it works for you.

[cofinley]

I was mainly looking for updated wtforms. This is a step in the right direction though. I've updated the forms part on my clone, but kind of towards a side project which may not fall in line with the styling here. Thank you again.

[OverlordQ]

Yeah, the main issue I've found is the WTForms macros will need a heavy overhaul for v4 forms. Otherwise @jeevcat's fork is WFM.

[beenje]

I'll try to make a proper pull request starting from @jeevcat repository.

[beenje]

I just created the pull request https://github.com/mbr/flask-bootstrap/pull/164

[MelleB]

What do we need to push this forward?

[mbr]

I will be looking into this on Sunday.

The current blocker is that I want to deprecate quick_forms in favor of the new, dominate-based quick_forms which has much more maintaineable code. Otherwise, I would have done this already.

On Tue, Apr 10, 2018 at 2:53 PM, Melle notifications@github.com wrote:

What do we need to push this forward?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/mbr/flask-bootstrap/issues/162#issuecomment-380087331, or mute the thread https://github.com/notifications/unsubscribe-auth/AAGv8cssD4lh1EOyhmHRQCwAFZTUym2Xks5tnKsugaJpZM4OJq_Y .

[mbr]

And FWIW, I am sorry for the delay =(

On Tue, Apr 10, 2018 at 3:06 PM, Marc Brinkmann git@marcbrinkmann.de wrote:

I will be looking into this on Sunday.

The current blocker is that I want to deprecate quick_forms in favor of the new, dominate-based quick_forms which has much more maintaineable code. Otherwise, I would have done this already.

On Tue, Apr 10, 2018 at 2:53 PM, Melle notifications@github.com wrote:

What do we need to push this forward?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/mbr/flask-bootstrap/issues/162#issuecomment-380087331, or mute the thread https://github.com/notifications/unsubscribe-auth/AAGv8cssD4lh1EOyhmHRQCwAFZTUym2Xks5tnKsugaJpZM4OJq_Y .

[cofinley]

Recent bug I found with the 4.0 branch is that pagination.html needs the appropriate .page-link and .page-item classes.

[mcnullity]

Eagerly waiting...

[joncutrer]

+1

[slidenerd]

Bootstrap 4 has moved well into the beta version guys, any updates on this?

[zgoda]

B4 left beta back in January, now it's at 4.1.1.

[greyli]

For people who interested, I am maintaining Bootstrap-Flask that based on Flask-Bootstrap and support Bootstrap 4.

[louisguitton]

Would love to see this as well, as I'm using cards for example.

[jaikumarm]

+1

[joaqo]

+1

[hfilimonescu]

Hi Marc, I was wondering why all this trouble with dominate? WTForms generate the html with __call__. Am I missing something?

I ask because I might be prepared to do some work on this issue, but first I need to understand the choices and restrictions.

Best regards

[yurzo]

Same here, I'm new to Bootstrap and Flask yet the docs and ideas behind flask-bootstrap are gorgeous so I'm interested in seeing it move forward

[mpounsett]

It's been 2 years since the last commit to this repo, and over a year since (it seems like) @jeevcat 's patch was finalized. Given the lack of activity, should we assume that this project is dead?

I really want to move my Flask projects to Bootstrap 4, but would like to avoid refactoring everything twice. If I move to some other solution and then this package comes back to life and I need to move back, that's going to be irritating.

[bartkamphorst]

Ping @mbr. Would also love for bootstrap 4 to be supported. Thanks in advance!

[ghost]

Likewise ping @mbr. Really looking to move to bootstrap 4 (including with WTF) so be good to know if this is imminent or whether I should roll my own. TIA!

[bartkamphorst]

@mbr Any updates regarding bootstrap 4 support?

[hfilimonescu]

@bartkamphorst I have made a new package witg Bootstrap 4, based on Flask-Bootstrap. If you want, you can give it a spin. Flask-BS4

[maxtrem]

This issue has been open now for 3 years. Seems to be quite dead.

on 10 Apr 2018: I will be looking into this on Sunday.

Will there still be a version for bootstrap 4?

[mpounsett]

@mbr Maybe it's time to find a new maintainer for this project?