mbr / simplekv

A simple key-value store for binary data.
http://simplekv.readthedocs.io
MIT License
152 stars 50 forks source link

Check type of data on put #42

Closed criemen closed 7 years ago

criemen commented 7 years ago

Hi,

not all backends (at least not S3/boto) check that the data supplied in a put is of type bytes. In S3, it is possible to store unicode data. This leads to bugs in applications which are developed against S3 which switch backends later. This PR checks the type and adds a test for this behauviour.

This depends on #39 for green tests.

fmarczin commented 7 years ago

Looks good to me 👍