search

mbr / simplekv

A simple key-value store for binary data.
http://simplekv.readthedocs.io
MIT License
152 stars 50 forks source link

don't leak file descriptor #81

Closed crepererum closed 6 years ago

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-8.2%) to 81.142% when pulling d5ab32269c6581b582b14c999644d1d10d755818 on crepererum:fix_fd_leak into 83b817a07ef307f48d43f859ade959fecb6c13aa on mbr:master.

criemen commented 6 years ago

Thank you very much for your contribution! Can you add an entry to the Changelog? Then I can merge the PR.

Please ignore the decreasing coverage, this happens for all external contributions, as the azure tests are not executed.

crepererum commented 6 years ago

Will do so on Monday 🙂

crepererum commented 6 years ago

@Corni done 👍

criemen commented 6 years ago

I will prepare a release, but because of the ongoing github issues travis doesn't work at the moment. If I forget about preparing a release, please do remind me in a few days.

criemen commented 6 years ago

@crepererum The release with your bugfix is now on PyPi.