mbr / tinyrpc

A compact, modular transport and protocol agnostic RPC library. Does jsonrpc v2.
https://tinyrpc.readthedocs.org
MIT License
156 stars 53 forks source link

support for python3 #12

Closed alpae closed 7 years ago

alpae commented 10 years ago

Hi Marc, do you have plans to port tinyrpc to python3? among your transport layers, at least zmq supports python3 now. Or can you see any reason why porting shouldn't be possible? Cheers Adrian

mbr commented 10 years ago

The only thing stopping me right now is time constraints. Eventually, there will be a python 3 port!

ghost commented 10 years ago

Hi, I just forked tinyrpc to see what I could do to make it py3k compatible.. but when I set it up and ran the tests, I got no output. Does this mean it's Py3k compatible already? I'm not familiar with mock! If so, bravo! I love JRPC, happy to see a version written that attempts to be transport agnostic.

mbr commented 10 years ago

I've recently started to slowly port all my projects over to Python3 and get working py.test/travis builds (like https://travis-ci.org/mbr/simplekv). Unfortunately, since I've got a lot of repos to port, this may take a while.

Any project of mine that officially supports Python3 will have a tox.ini (and probably a .travis.yml). So, no, I haven't tested it yet, I'm sorry. Hopefully, I'll get around to that soon.

ghost commented 10 years ago

Well, I know it's not "official", I'm just pointing out that it seems to pass all the Mock tests; what about this mightn't be py3k compatible already? Might it simply already work?

Bravo on migrating!

On 08/03/14 22:49, Marc Brinkmann wrote:

I've recently started to slowly port all my projects over to Python3 and get working py.test/travis builds (like https://travis-ci.org/mbr/simplekv). Unfortunately, since I've got a lot of repos to port, this may take a while.

Any project of mine that officially supports Python3 will have a tox.ini (and probably a .travis.yml). So, no, I haven't tested it yet, I'm sorry. Hopefully, I'll get around to that soon.


Reply to this email directly or view it on GitHub: https://github.com/mbr/tinyrpc/issues/12#issuecomment-37112440

Please help support my crowdfunding campaign, IndieBB: Currently at 44.8% of funding goal, with 5 days left: http://igg.me/at/yourfirstgmo/x/4252296 T: @onetruecathal, @IndieBBDNA P: +3538763663185 W: http://indiebiotech.com

mbr commented 10 years ago

If it passes all the tests, there's a good chance it works already. Give it a shot! I certainly did not insist on making sure that it doesn't work =).

On Sat, Mar 8, 2014 at 11:50 PM, Cathal Garvey notifications@github.comwrote:

Well, I know it's not "official", I'm just pointing out that it seems to pass all the Mock tests; what about this mightn't be py3k compatible already? Might it simply already work?

Bravo on migrating!

On 08/03/14 22:49, Marc Brinkmann wrote:

I've recently started to slowly port all my projects over to Python3 and get working py.test/travis builds (like https://travis-ci.org/mbr/simplekv). Unfortunately, since I've got a lot of repos to port, this may take a while.

Any project of mine that officially supports Python3 will have a tox.ini (and probably a .travis.yml). So, no, I haven't tested it yet, I'm sorry. Hopefully, I'll get around to that soon.


Reply to this email directly or view it on GitHub: https://github.com/mbr/tinyrpc/issues/12#issuecomment-37112440

Please help support my crowdfunding campaign, IndieBB: Currently at 44.8% of funding goal, with 5 days left: http://igg.me/at/yourfirstgmo/x/4252296 T: @onetruecathal, @IndieBBDNA P: +3538763663185 W: http://indiebiotech.com

— Reply to this email directly or view it on GitHubhttps://github.com/mbr/tinyrpc/issues/12#issuecomment-37112496 .

mivade commented 8 years ago

A new release on PyPI would be nice. The current version that is up there is not Python 3-compatible:

AttributeError: 'dict' object has no attribute 'iterkeys'

Looking at the code, this appears to have been fixed via six, though.

frenzymadness commented 8 years ago

Hello.

Is there any progress with Py3 compatibility? I am thinking about package this module to Fedora but before this, I need to be sure that this module is Py3 compatible.

I've tried to install it via setup.py install and run test via python -m pytest tests/ and tests failed due to a lot of missing dependencies. Why there is no requirements.txt file? After installation of all necessary dependencies (listed below) tests with Py2 looks ok but with Py3 fails due to missing httplib.

I will create pull request with requirements.txt/test_requirements.txt files.

Please, let me know if I can help you with something.

Dependencies which I found:

frenzymadness commented 8 years ago

I've just read the discussion on mentioned PR and I have same issues with some tests:

All other tests works fine in Python 3.5.1.

Also, imports of Queue and httplib should be replaced with six.moves.

Have a nice weekend.

lnoor commented 7 years ago

Closing but see #36