mbr / tinyrpc

A compact, modular transport and protocol agnostic RPC library. Does jsonrpc v2.
https://tinyrpc.readthedocs.org
MIT License
156 stars 53 forks source link

Restore tinyrpc0.7 as it is breaking openstack install #46

Closed jasmohan-narula closed 6 years ago

jasmohan-narula commented 6 years ago

Without this requirement, Openstack is not installing.

stenioaraujo commented 6 years ago

Hi @Jasmohan-ThandaLe, a solution has been proposed by Pavlo on the openstack/requirements project: https://review.openstack.org/#/c/545025/

jasmohan-narula commented 6 years ago

stenioaraujo, I couldn't figure it out on that site. Could you please tell me the steps if you know?

stenioaraujo commented 6 years ago

@Jasmohan-ThandaLe the link I sent you was the fix proposed to the openstack/requirements project. It is being reviewed and will be merged soon. Once it is merged, the problem is gone.

I was having this issue while trying to run the tests within Neutron, since the requirement is still 0.7, it doesn't work.

My workaround was the following: Before running the command to run the tests (tox) I export the env variable UPPER_CONSTRAINTS_FILE, this will be used as the upper constraint file, instead of the original one: https://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt

export UPPER_CONSTRAINTS_FILE=https://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt?h=refs/changes/25/545025/1

Maybe you can try to export this variable before starting the OpenStack installation.

In any case, the fix will be released soon.

jasmohan-narula commented 6 years ago

@stenioaraujo Thank for the clarification.

I fixed the problem.

after running ./stack the installation is failing due to tinyrpc0.7 requirement and current version available is 0.8

So, after the installation is failing, I edited the file upper-constraints.txt with command nano /opt/stack/requirements/upper-constraints.txt

I changed the 209th line from tinyrpc===0.7 to tinyrpc===0.8

saved the changes and ran the install again with ./stack . This solved the issue and installation of openstack is progressing.

lnoor commented 6 years ago

I apologize for the trouble I caused. 0.7 was flawed and I thought I could replace it without incrementing the release. So I removed the installable planning to replace it with the correct one. But pypi doesn't let me reuse a version number. So I had to create a new version (should have done that first time round I know).