mbraak / jqTree

Tree widget for jQuery
https://mbraak.github.io/jqTree/
Apache License 2.0
1.02k stars 177 forks source link

'e' instead of 'event' in event documentation #64

Closed peterrus closed 12 years ago

peterrus commented 12 years ago

In the documentation I find the following (http://mbraak.github.com/jqTree/#event-tree-move)

$('#tree1').tree({
    data: data,
    dragAndDrop: true
});

$('#tree1).bind(
    'tree.move',
    function(event) {
        console.log('moved_node', e.move_info.moved_node);
        console.log('target_node', e.move_info.target_node);
        console.log('position', e.move_info.position);
        console.log('previous_parent', e.move_info.previous_parent);
    }
);

the four references to 'e' should be 'event'

rosenfeld commented 12 years ago

Feel free to fix it:

https://github.com/mbraak/jqTree/blob/master/index.html#L903

You could do the entire pull request using the GitHub built-in edit interface for something simple like this.

Thanks for reporting it.

rosenfeld commented 12 years ago

Thank you, @peterrus. Alternatively you could have just changed L903, but either way is good to me. Let's wait for @mbraak to merge it :)

peterrus commented 12 years ago

Not sure what I did wrong there?

rosenfeld commented 12 years ago

Nothing wrong. It is just that I'd probably change L903 to "function(e) {" instead :)

peterrus commented 12 years ago

I chose for event instead of e as the rest of the examples also use event ;)

On Wed, Aug 15, 2012 at 2:56 AM, Rodrigo Rosenfeld Rosas < notifications@github.com> wrote:

Nothing wrong. It is just that I'd probably change L903 to "function(e) {" instead :)

— Reply to this email directly or view it on GitHubhttps://github.com/mbraak/jqTree/issues/64#issuecomment-7745286.

rosenfeld commented 12 years ago

As I said before, just a matter of style, nothing to worry about :)

mbraak commented 12 years ago

Thank you. I merged the pull request.