mbraak / jqTree

Tree widget for jQuery
https://mbraak.github.io/jqTree/
Apache License 2.0
1.02k stars 177 forks source link

Altered CSS for 'buttonleft=false' in case of multi-line entries #675

Closed odungern closed 1 year ago

odungern commented 2 years ago

Hi Marco, thanks for including the fix for 'buttonleft=false' in 1.6.2.

The default CSS however yields a suboptimal placing of the button, in case the entry does not fit on a single line.

You have given me the following advice:

This is what I get with the default css:

Schermafbeelding 2021-10-20 om 14 56 37

The button is aligned to the right, but only when the title is on multiple lines. I don't know why that is.

When I remove display: flex; from the ul.jqtree-tree .jqtree-element element, I get:

Schermafbeelding 2021-10-20 om 15 01 45

This looks better. Perhaps this is a good option when the button is on the right. Could you try if this works for you?

Yes, this has worked for me .. and I prefer this placing, as well.

mbraak commented 2 years ago

I will look into it.

odungern commented 2 years ago

... take your time ... for now we are serving a 'private' version of the CSS with the recommended change.

odungern commented 2 years ago

.. sorry, to thick a thumb hit the wrong button

odungern commented 1 year ago

thanks! Have tried to verify with the latest (1.7.1). Unfortunately it does not work for us ... so we stay with our private CSS for the time being. I now see that the changelog for 1.7.1 does not list #675 ... so we will wait for the next release ... no worries and no hurry. jqtree-button-right-1 7 1

mbraak commented 1 year ago

There is a pr with a fix: #748.

It works on my system and the Chrome browser.

The only thing that has changes is the css: https://github.com/mbraak/jqTree/blob/toggler-right-with-multiline/jqtree.css

mbraak commented 1 year ago

The pr with the fix is merged. There is no new release yet.

mbraak commented 1 year ago

The fix is included in release 1.7.4

odungern commented 7 months ago

Tested with 1.8.0: Toggler on the right works fine (also in our app) when the line is split to multiple lines. Thanks a lot Marco!