search

mbraceproject / FsPickler

A fast multi-format message serializer for .NET
http://mbraceproject.github.io/FsPickler/
MIT License
326 stars 51 forks source link

Fixing pickling directory info #106

Closed JackMatusiewicz closed 6 years ago

JackMatusiewicz commented 6 years ago

This fixes our issue regarding the pickling of a directory info. I've chosen to move the custom pickler up, rather than changing where the isUnsupportedType check happens. The rationale behind this is that if a user provides a custom pickler that is probably what should be used.

JackMatusiewicz commented 6 years ago

Fixed, do you think a comment would be useful explaining why the unsupported check is now part way down the list?

eiriktsarpalis commented 6 years ago

Sure, maybe even a test that demonstrates DirectoryInfo is serializable using a custom pickler would be good.

eiriktsarpalis commented 6 years ago

Thanks