mbraceproject / FsPickler

A fast multi-format message serializer for .NET
http://mbraceproject.github.io/FsPickler/
MIT License
324 stars 52 forks source link

FsPickler.Json: Version of Newtonsoft.Json #48

Closed ascjones closed 9 years ago

ascjones commented 9 years ago

Hi Eirik

I want to upgrade to 1.2.5 (for the excellent new custom pickler registration feature), but am unable to because the version of Newtonsoft.Json in FsPickler.Json is now pinned to 6.0.5 since the Paket upgrade:

image

In version 1.2.4 it was (perhaps not intentionally) unrestricted above 6.0.5:

image

Another of my dependencies depends on the latest stable: 6.0.8, and since I'm using Paket it resolves to the latest version with compatible version constraints: in this case 1.2.4

Just checking that this is intentional, since I know that Newtonsoft.Json is not exactly famous for confirming to SemVer between patch versions. However it could just be a consequence of the Paket conversion.

If so I suggest relaxing the version constraint in paket.dependencies to ~> 6.0.5, which I believe will resolve to >= 6.0.5 && < 6.1 in the nuspec. This is slightly tighter than the original >= 6.0.5 constraint.

Cheers,

Andrew

eiriktsarpalis commented 9 years ago

Yes, this was caused inadvertently in the recent migration to paket pack. It's been fixed in 1.2.6.

ascjones commented 9 years ago

Thanks for the quick fix Eirik!