Added Unity3D build

[cloudRoutine]

I noticed the discussion about Unity3d support so I tried using FsPickler inside the engine but it couldn't load properly due to incompatible dependencies and function/method calls.

The new project FsPickler.Unity3D is in the "platforms" folder using links to all the original files. The project is targeting the Unity 3.5 .net Base Class Libraries framework. You may need to have the Unity Engine installed on your machine in order to select it in the Target Framework dropdown in the project's properties view. If you can't build it on your machine that might be the issue.

There is a new compiler directive UNITY that was inserted wherever necessary to ensure compatibility with the framework.

System.Numerics is not available on this platform so I added the reference to System.Threading via the TaskParallelLibrary package off of Nuget.

The "build.fsx" was not modified to include this new project.

This modified version successfully loads in the Unity3D engine.

[eiriktsarpalis]

Hi,

Thanks for taking the time to write this. I have a few misgivings about this particular PR for the following reasons:

• I am not a big friend of mirror projects that link to files of the original. It hampers flexibility when making changes to the project structure. In most cases I prefer using custom build configurations, even if this means editing some msbuild code by hand. FsPickler build configuration for net35 is one possible reference of how this can be done.
• The PR introduces boolean expressions in compile-time conditionals. While these are overall nice features, they were only just recently introduced in F# 4.0 so they break compatibility with older F# build environments. This is why the travis builds seem to be failing here.
• I do not have access to Unity so I cannot test the changes myself or write meaningful unit tests.

I guess the first two points stand out here, I could accept this once they are resolved. Another avenue is to maintain this as a fork, like the Tachyus guys have done with Xamarin support.

Thanks,

[cloudRoutine]

It seems like it'd be easier for me to maintain a fork since you don't have access to Unity and ideally a lot of the testing would need to happen inside a running instance of the engine. Plus it'd be easier to make tweaks specifically for easier usage in that context.

Thanks for the feedback

[eiriktsarpalis]

I'd still be happy to accept changes that make building for unity environments easier. For instance all the changes of type

#if UNITY
    propertyInfo.GetValue(o, [||])
#else
    propertyInfo.GetValue(o)
#endif

I would just like these to avoid F# 4.0 boolean expressions (for now).

[cloudRoutine]

Cool, I'll try to clean them up and submit a new PR soon.

[varon]

@cloudRoutine Did you have any success with this? It's something I'd be interested in as well.

[cloudRoutine]

I ran into some intractable issues in the project I wanted to use FsPickler for, so I put it aside and forgot I said I'd do this X_X