omitHeader in bson serializer

mbraceproject / FsPickler

A fast multi-format message serializer for .NET

http://mbraceproject.github.io/FsPickler/

MIT License

324 stars 52 forks source link

Closed vilinski closed 6 years ago

vilinski commented 8 years ago

I could make a PR, but it seems difficult

in mono the unit tests are broken because of this bug (already fixed)
in windows the additional tests for bson without header are broken for me also, perhaps because bson needs always to be a document, but primitives and arrays are not if there is no header document, containing serialized value
in mono i have some failed performance tests regardless of my changes, dunno if it was already so in the latest git stand

eiriktsarpalis commented 8 years ago

Hi, what is the issue exactly?

Performance tests are not really unit tests, some of them are expected to fail from time to time.

vilinski commented 8 years ago

created a test PR #72

eiriktsarpalis commented 6 years ago

BSON is being deprecated by Newtonsoft, so don't think this is relevant anymore.