search

mbraceproject / FsPickler

A fast multi-format message serializer for .NET
http://mbraceproject.github.io/FsPickler/
MIT License
326 stars 51 forks source link

potential fix for #80 #81

Closed 0x53A closed 7 years ago

0x53A commented 7 years ago

ref https://github.com/mbraceproject/FsPickler/issues/80

I'm not sure if you even want to enable that scenario, since it may introduce non-determinism, but I think it would make sense ..

dsyme commented 7 years ago

@eiriktsarpalis Closing out old issues and PRs to keep the repo in good shape - what do you think of this one?

0x53A commented 7 years ago

For context, I am currently running this as a fork in production, otherwise it is impossible (or at least I didn't find another way) to correctly serialize akka.net objects.

The pr was mostly meant as a starting point for a discussion.

dsyme commented 7 years ago

@eiriktsarpalis Can we accept this? I approve it but my understanding of the code is not that good

eiriktsarpalis commented 7 years ago

@dsyme Please see my comments in #80

eiriktsarpalis commented 7 years ago

Fixed in FsPickler 4.0

0x53A commented 7 years ago

Thanks!

~I don't want to be too annoying, but nuget release when? ;-)~

❤️

eiriktsarpalis commented 7 years ago

Just released

On Sun, 17 Sep 2017 at 01:23 Lukas Rieger notifications@github.com wrote:

Thanks!

I don't want to be too annoying, but nuget release when? ;-)

— You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub https://github.com/mbraceproject/FsPickler/pull/81#issuecomment-330003424, or mute the thread https://github.com/notifications/unsubscribe-auth/ACrts2-4_MTrR6sKFU1ABJvqU_F0RnBtks5sjGaGgaJpZM4MMepu .