search

mbraceproject / MBrace.Core

MBrace Core Libraries & Runtime Foundations
http://mbrace.io/
Apache License 2.0
211 stars 46 forks source link

CloudFileReader - is it needed #25

Closed dsyme closed 9 years ago

dsyme commented 9 years ago

I notice the CloudFileReader type, https://github.com/mbraceproject/MBrace.Core/blob/597057804bd7d991c82f3366541283699769e5c9/src/MBrace.Streams/Readers.fs#L7

Does this need to be public anymore, now that CloudFile.ReadAllLines and friends are there? In what case would the user refer to these explicitly?

krontogiannis commented 9 years ago

The CloudFileReader type is part of the MBrace.Streams namespace and is meant to be used as an argument in CloudStream.ofCloudFiles (reader : System.IO.Stream -> Async<'T>) (sources : seq<CloudFile>) : CloudStream<'T>.

I believe at some point at least the case with the ReadLines reader will become a separate method like: CloudStream.ofCloudFileLines or sth.

dsyme commented 9 years ago

OK, that makes sense. I'll close this for now.