mbrevoort / node-reggie

An experimental light weight alternative to a full blown npm registry
416 stars 50 forks source link

Add travis-ci build #16

Closed bajtos closed 11 years ago

bajtos commented 11 years ago

Hi @mbrevoort,

Could you please enable travis-ci hook for this repository? I'd like to setup a CI build server for Reggie and add badge to README.md. See steps 1 & 2 in Travis CI: Getting Started.

I can do the rest (add .travis.yml, etc.) to get CI up and running.

mbrevoort commented 11 years ago

Hey, yes, I just enabled travis on the reggie repo.

Also, I liked your contributor rules. Do you want to add a section at the end of the README with the same details?

Thanks! Mike

On Mon, Sep 2, 2013 at 10:48 AM, Miroslav Bajtoš notifications@github.comwrote:

Hi @mbrevoort https://github.com/mbrevoort,

Could you please enable travis-ci hook for this repository? I'd like to setup a CI build server for Reggie and add badge to README.md. See steps 1 & 2 in Travis CI: Getting Startedhttp://about.travis-ci.org/docs/user/getting-started/#Step-one%3A-Sign-in .

I can do the rest (add .travis.yml, etc.) to get CI up and running.

— Reply to this email directly or view it on GitHubhttps://github.com/mbrevoort/node-reggie/issues/16 .

bajtos commented 11 years ago

I just enabled travis on the reggie repo.

Excellent! The build is failing now, I'll investigate and fix the problem.

Also, I liked your contributor rules. Do you want to add a section at the end of the README with the same details?

Do you mean the 50/72 rule for commit messages? Here is what I did for Node Inspector, perhaps I can copy the content to Reggie?

I am also thinking about adding .jshintrc and configuring travis to run jshint as a pre-build script. This should keep the coding style clean and consistent. Any objections? Here is my preferred jshint config: .jshintrc

bajtos commented 11 years ago

Contributor rules were added in d5f3013. I am closing the issue.