search

mbrezu / cl-messagepack

A Common Lisp implementation of Message Pack
BSD 2-Clause "Simplified" License
29 stars 13 forks source link

Properly decoding byte arrays for bin and ext formats #10

Closed adolenc closed 8 years ago

adolenc commented 8 years ago

The data in specification for bin format and ext format is an actual byte array with N bytes, not an array of N objects as in array format.

Also a quick question about EXTENSION-TYPES and EXTENSION-TYPES-DECODING tests: both of them fail for me with an "Invalid initialization argument: :id" error. I cannot get them to work even on commit 68e5b0906 which if I understand correctly was supposed to fix this issue. Could you please confirm that the tests work on your end so I can be sure the problem is somewhere locally with me?

phmarek commented 8 years ago

Thank you.

adolenc commented 8 years ago

I see you fixed the ext-type equality and related tests as well, very cool, thanks :+1: