mbridak / FieldDayLogger

ARRL Field Day Logger written in Python using Qt5
https://mbridak.github.io/FieldDayLogger/
GNU General Public License v3.0
24 stars 6 forks source link

A few fixes to the N1MM UDP ContactInfo message #37

Closed ny4i closed 8 months ago

ny4i commented 8 months ago

The format of the band field in the ContactInfo UDP message sent to the Dashboard and n1mm_view was incorrect.

Also, if the radio was not connected, the mode sent was incorrect.

Lastly if the CAT connection was set to rigctld, but no radio was running (as in rigctld was not running), the rxfreq and txfreq sent was set to 0. The code will not use the fakefreq function if those frequencies are zero.

Note I suspect the same issue with the band info exists in your NotN1MM logger as well as Winter Field Day. I did not propagate this change to those repos.

This PR would close issue #36 .

Note the code I added to check if the frequency is zero could be moved into the n1mm library as an edit check on the way out. That would make the change more modular but would contribute to post-check edit processing which may not be desirable.

mbridak commented 8 months ago

Thanks for the PR.