mbrlabs / Lorien

Infinite canvas drawing/whiteboarding app for Windows, Linux and macOS. Made with Godot.
MIT License
5.55k stars 241 forks source link

Drawing with Windows Ink may require a double tap #158

Closed Eevoo closed 11 months ago

Eevoo commented 2 years ago

Lorien version: v0.5.0

OS/device including version:

Windows 10 21H2 image

Issue description:

When using an active stylus using an "HID Compliant Pen" (which I can't remember whether it's a Wacom AES or a MPP touchscreen but either way it uses an active stylus that has pressure sensitivity, an erase button etc), Lorien does not draw strokes when the pen is pressed against the screen.

Lorien does detect that there is pressure however, as shown in the demo pic below.

Holding the middle, left, or eraser buttons while drawing does not appear to have any effect.

Repro steps:

  1. Attempt to draw with the pen as normal
  2. Observe no lines are drawn, but note that there is pressure reported from the program

Demo graphic:

The strokes on the left are attempted with a single tap and hold to draw, the strokes on the right are attempted with a double-tap and hold to draw.

GIF 2022-06-16 5-50-56 PM

Workaround:

Attempt a double-tap to cause Windows to send a mousedown event, then hold the pen down for the stroke.

hansemro commented 2 years ago

@Eevoo This could be an issue with how godot engine processes inputs for your stylus. Can you provide additional hardware details? I was unable to replicate this.

Eevoo commented 2 years ago

@hansemro sure. It is an HP ProBook 435 x360. https://www.notebookcheck.net/HP-ProBook-x360-435-G7-laptop-review-AMD-Ryzen-also-shines-in-the-business-convertible.494446.0.html and the stylus is https://www.hp.com/us-en/shop/pdp/hp-rechargeable-active-pen-g3#techSpecs which as best I can tell from the Q and A, is Wacom AES based technology.

Once I'm not running around on mobile I can try to pull specific drivers if that helps? Or if there is any other way I could gather mouse down events in a way that would be useful for Godot event handlers I'm happy to that too.

lieuzhenghong commented 2 years ago

I have the same problem with a Surface Pen 2 on a Surface Pro 8 and the latest release of Lorien.

hansemro commented 2 years ago

@lieuzhenghong and @Eevoo: Can you try both wintab and winink driver options in Lorien? I'd like to know if both have the same issue.

1) Create a shortcut to Lorien.exe 2) Right click, then go to Properties 3) Under Target, append --tablet-driver wintab or --tablet-driver winink 4) Launch from shortcut

image

Eevoo commented 2 years ago

@hansemro hey there.

I created both shortcuts and attempted to test with both options. The --tablet-driver winink has the original symptoms reported here. The --tablet-driver wintab option is in a separate shortcut, but no window opens when I attempt to launch lorien via that method.

lieuzhenghong commented 2 years ago

@hansemro @Eevoo following up here.

I can confirm @Eevoo's observations exactly:

Eevoo commented 11 months ago

Hello all, I tried this same test on the same device with the same stylus, running Lorien 0.6.0. Success! I can now draw with a single tap and hold as expected when I opened this last year. The pressure shown is 0, then 1, and there is no pressure sensitivity at the moment, but for now, I'm happy that there is forward progress on this and can open another incident if I can't play around with the pressure sensitivity settings later and decide I 'must' have that feature.

Thanks for making such a cool product and sharing it with us web freeloaders!