search

mbrlabs / Lorien

Infinite canvas drawing/whiteboarding app for Windows, Linux and macOS. Made with Godot.
MIT License
5.12k stars 219 forks source link

Line thickness inconsistencies in Windows #252

Closed gitkeerthi closed 3 months ago

gitkeerthi commented 7 months ago

Lorien version: 0.6.0

OS/device including version: Windows 11

Issue description: Line thickness of objects (rectangle, circle, etc.) does not match that of handwritten text for the same brush size. Only observed in Windows. Looks good in Linux.

Steps to reproduce: See screenshot Screenshot 2023-11-13 095453

tafode commented 4 months ago

I tried to find the issue. I think the problem is, that the pressure for Circle/Rectangle is set as a constant to 0.5. This would mean the line is always half the size of the brush, but additional the interpolate function is called with 0.5 which looks up the pressure inside a pressure curve which decreases the size again. (e.g. CircleTool.gd line 55 pressure = pressure_curve.interpolate(pressure).

In my opinion setting the constant to 1 would solve the problem. Lorien

I don't know how or why it should work on Linux and I have at the moment no possibility to check it on Linux.

mbrlabs commented 3 months ago

Fixed with #263