mbrlabs / Lorien

Infinite canvas drawing/whiteboarding app for Windows, Linux and macOS. Made with Godot.
MIT License
5.55k stars 241 forks source link

Disable stroke while panning or zooming #302

Closed Zacrain closed 2 months ago

Zacrain commented 2 months ago

Closes #301 .

Branched off main. Tested in debug and Windows release export.

Notable changes and explanation of new behaviour:

Observed bugs:

Zacrain commented 2 months ago

Remark: I made a small mistake in the commit message. I've written "draw button", but just meant "drawing". Idk where the button came from. Sry.

mbrlabs commented 2 months ago

Sometimes, while drawing, panning and or zooming, the cursor might disappear / become invisible. It will reappear upon drawing somewhere again. I was not able to reproduce this issue reliably though.

Yeah, that's a bug i'm aware of. It has to do with how the app handles input focus. It manually disables/enables the canvas based on where the mouse is and other input events. It's quite messy and needs a rework honestly :sweat_smile: