search

mbroadst / qamqp

AMQP 0.9.1 implementation for Qt
Other
151 stars 127 forks source link

Minor changes. #4

Closed AdamMajer closed 10 years ago

AdamMajer commented 10 years ago

I've rearranged some code, pulling the frame processing code to a seperate function. This removes 2 indentation steps and hopefully makes things easier to understand. Logic was not changed.

The alignment issue is actually very easy to fix. Qt provides a function to parse byte data into numbers fixing its endian format.

Also, on UNIX, unit tests do not run because library is not found without either setting rpath or LD_LIBRARY_PATH. Since it's only unit tests, rpath is good enough.

mbroadst commented 10 years ago

Aside from the comment above, it all looks good to me, thanks :)

mbroadst commented 10 years ago

merged with 1eea37cb6f26b3af9086c5910b107311f0778370 thanks!