search

mbroadst / qamqp

AMQP 0.9.1 implementation for Qt
Other
151 stars 127 forks source link

Qt 6 support #81

Closed DmitryDemidov80 closed 6 months ago

DmitryDemidov80 commented 2 years ago

Hi! Will be Qt 6 support? Now it has compile errors.

Needs

include QIODevice

and problem with QHash::unite()

Thanks!

AntonOrnatskyi commented 2 years ago

And QSslSocket::error signal was obsolete

droidsyer commented 2 years ago

Some days ago, I made porting on Qt6. It was easy and fast. As soon as possible I should make a pull request. But I didn't tried to compile with Qt4.

moruoxian commented 1 year ago

you can add this in your main qRegisterMetaType();

WollZebra commented 1 year ago

Hi, I tried a port for Qt6.5. It is not a real problem. @mbroadst shall I open a branch + pull request here? If not I will fork it. Qt4 support I would drop then. Qt themself did it long ago.

mbroadst commented 1 year ago

Hi @WollZebra, sure please do that. I haven't been using this library for some time, so I'm also interested in discussing sharing the maintenance with more actively-involved community members. Let me know if you're interested

WollZebra commented 1 year ago

Good morning @mbroadst , yes I will help you to maintain this library. It is still very useful. So I have my local branch. Please grand me permission to push branches.

git.exe push --set-upstream --progress "origin" chore/support-Qt6-and-drop-Qt4:chore/support-Qt6-and-drop-Qt4
remote: Permission to mbroadst/qamqp.git denied to WollZebra.
fatal: unable to access 'https://github.com/mbroadst/qamqp.git/': The requested URL returned error: 403
mbroadst commented 1 year ago

@WollZebra let's work through a pull request together first, before discussing maintaining the project 😄 . Can you submit a pull request from your fork?

WollZebra commented 1 year ago

@mbroadst the Pullrequest is open for you and all others xD

WollZebra commented 1 year ago

@mbroadst it would be really nice if you could review my PR. We are already on the next challenge, to use it with Qt for WebAssemby. Key problem here is the use of it as external lib.

mbroadst commented 1 year ago

@WollZebra it's been approved. I saw that CI was broken, it might be a good next step to set up CI using GitHub actions? I tried to re-enable TravisCI but it looks like its broken, or somehow conflicting with my work account.