search

mbround18 / valheim-docker

Valheim Docker powered by Odin. The Valheim dedicated gameserver manager which is designed with resiliency in mind by providing automatic updates, world backup support, and a user friendly cli interface.
https://hub.docker.com/r/mbround18/valheim
BSD 3-Clause "New" or "Revised" License
767 stars 82 forks source link

Setting UID / PID can have big issues on shared servers #23

Closed Webrow closed 3 years ago

Webrow commented 3 years ago

Hey,

Setting UID / PID can have major issues (in my case all files of the server are owned by another user, if you are not able to sudo you will be unable to chown the files. Might it be an idea to introduce a user created in the alpine image and from there connect it. Yes itll cause write / read issues during copying of savegames into temp, but isnt that how it is supposed to work (or maybe use whoami to determine who is building the Dockerfile instead of hardcoding it?)

MattPark commented 3 years ago

It's fixed in latest. See #16. You can set to whatever you need to using PGID/PUID env variable

Webrow commented 3 years ago

Hey Matt, its not regarding the matter that its fixed, just that it defaults to 1000. 1000 is not always your own user, and knowing it later on can cause bigger issues. (I assume 1000 was chosen cause often its the first user). Nevertheless its a nitpick. Ill close it!

MattPark commented 3 years ago

Yeah I mean I see your point though. 1000:1000 was not a real user or group on my system. The ideal default should probably be the result of id -u and id -g ... not a huge deal since this fix gives everyone the option whereas option was missing before.

Webrow commented 3 years ago

Agreed

Op wo 10 feb. 2021 00:06 schreef Matt Park notifications@github.com:

Yeah I mean I see your point though. Like ideal default should be the result of id -u and id -g probably ... not a huge deal since this fix gives everyone the option whereas option was missing before.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/mbround18/valheim-docker/issues/23#issuecomment-776304227, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAYH27KYXJ66AUXXNQU4X3LS6G5YHANCNFSM4XL2GIUA .