mbround18 / valheim-docker

Valheim Docker powered by Odin. The Valheim dedicated gameserver manager which is designed with resiliency in mind by providing automatic updates, world backup support, and a user friendly cli interface.
https://hub.docker.com/r/mbround18/valheim
BSD 3-Clause "New" or "Revised" License
757 stars 81 forks source link

Fix for 772 and 773 #774

Closed mbround18 closed 7 months ago

mbround18 commented 7 months ago

Description

Contributions

Checklist

FooDeas commented 7 months ago

Build logs of d243267: log-build_odin.txt log-build_valheim.txt

mbround18 commented 7 months ago

:

Those look like successful logs, have you tried running the game server?

mbround18 commented 7 months ago

Found a new funny one, server only launches with old app id but old app id is dead. So i switch the app id right before launch. building canary now to test

mbround18 commented 7 months ago

Can confirm my server shows up in server browser image

FooDeas commented 7 months ago

I'm trying again with cd15943.

mbround18 commented 7 months ago

I see server in ingame browser too with status image

FooDeas commented 7 months ago

cd15943 starts now! But entering the console with gosu (and maybe the cronjob?) doesn't work:

steam@295714bb5ba6:~/valheim$ /usr/sbin/gosu steam /bin/bash /home/steam/scripts/auto_update.sh
error: failed switching to "steam": operation not permitted

There is another problem with the updater now:

steam@295714bb5ba6:~/valheim$ odin update
[ODIN][INFO]  - Checking for updates
thread 'main' panicked at src/odin/server/process.rs:38:10:
Failed to get process exe
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
mbround18 commented 7 months ago

thread 'main' panicked at src/odin/server/process.rs:38:10:

You shouldnt need gosu anymore, just exec into the container and it takes you in as steam user

mbround18 commented 7 months ago

Alright @FooDeas it was some formatting issues with the manifests, i fixed the brittleness with some regex. Arguably just as brittle but its the only option for right now. Sadly steam doesnt output json.

image

670f365 should be good to go :)

FooDeas commented 7 months ago

You shouldnt need gosu anymore, just exec into the container and it takes you in as steam user

That's what I thought and did. But there is the cron setup in the entrypoint.sh that won't work anymore.

mbround18 commented 7 months ago

Alrrirght @FooDeas thiissssss should work :) all features tested locally

FooDeas commented 7 months ago

Looks good! I can test it and give you feedback tomorrow, if you want.

FooDeas commented 7 months ago

It now works without any problems!