search

mbround18 / valheim-docker

Valheim Docker powered by Odin. The Valheim dedicated gameserver manager which is designed with resiliency in mind by providing automatic updates, world backup support, and a user friendly cli interface.
https://hub.docker.com/r/mbround18/valheim
BSD 3-Clause "New" or "Revised" License
766 stars 82 forks source link

Having to call odin stop because docker compose down doesnt save #812

Closed mbround18 closed 5 months ago

mbround18 commented 5 months ago

I just want to close the loop on at least part of this discussion. The issue with log files being empty seems to be resolved in https://github.com/mbround18/valheim-docker/pull/807 and I've tested this with my currently running dedicated server using the latest.

Unfortunately, my original report included 2 issues wrapped in one. I'd like to clarify that world save is occurring when I use the command docker exec tacticalsrealm-valheim-1 odin stop which I mentioned as "Method A" in the original post.

World save does NOT occur when I use the following command alone... docker-compose down which I mentioned as "Method B" in the original post.

I'm actually unsure if that is intended or not but I've just worked around it by using docker exec tacticalsrealm-valheim-1 odin stop followed by docker-compose down.

I am currently not using any mods and running Valheim quite vanilla.

Originally posted by @ericjgoebel in https://github.com/mbround18/valheim-docker/discussions/802#discussioncomment-9238545

mbround18 commented 5 months ago

@ericjgoebel good catch! after investigating for the past 5 hours i found valheim is spinning up new processes which were getting the interrupt signal before the main process was. After reworking the code i can find the trunk process and interrupt it with a CTRL C or docker compose down and see it save successfully. PR coming in shortly

ericjgoebel commented 5 months ago

I just had a moment to test this and, unfortunately, after pulling down the latest image I am still not seeing world save occur when it's expected.

Could the issue be related to my configuration? I suspect it may be related to https://github.com/mbround18/valheim-docker/discussions/809 which is arguably more of on issue for me personally. Let me know if there is anything else I can provide to determine the root cause.