search

mbrubeck / agate

Very simple server for the Gemini hypertext protocol
Apache License 2.0
610 stars 37 forks source link

specify allow(dead_code) to be only on windows in the Args struct #274

Closed w1kee closed 1 year ago

mbrubeck commented 1 year ago

Instead of allowing dead code, should we make this field #[cfg(unix)] so it just doesn't exist on other platforms?

Johann150 commented 1 year ago

That would also be a nice option, if @w1kee wants to do that. It would require adjusting a few more places in the code.

I wasn't sure if #[cfg(unix)] can be used on things like fields in constructors but apparently that works too.

Johann150 commented 1 year ago

Thanks for your contribution!