search

mbrucher / AudioTK

An audio digital processing toolbox based on a workflow/pipeline principle
https://github.com/AudioTK/AudioTK
BSD 3-Clause "New" or "Revised" License
251 stars 37 forks source link

Python chorus examples use non-existent filter class DoubleLowPassCoefficientsIIRFilter #8

Closed SpotlightKid closed 8 years ago

SpotlightKid commented 8 years ago

The example scripts Examples/delay/chorus.py and Examples/delay/display_chorus.py want to import the DoubleLowPassCoefficientsIIRFilter from the ATK.EQ module. This module doesn't have a class of that name (anymore?).

I looked a the filter classes in ATK/EQ.py, but I wasn't clear to me what would be a suitable replacement class. I tried DoubleRobertBristowJohnsonLowPassFilter and the scripts seem to work with it, but I'm not sure whether the effect is comparable.

mbrucher commented 8 years ago

Indeed, I've renamed in 1.2.0 all the second order filters,a s they didn't have the "second order" qualifier in their name. chorus and also the Python script that compared the low pass EQ should be fixed on the develop branch. Thanks again for all the reports!

SpotlightKid commented 8 years ago

I can confirm that the Python errors are fixed.

However, running Example/EQ/compare_ATK_LP.py I get several of the following warnings:

swig/python detected a memory leak of type 'std::vector< double > *', no destructor found.
mbrucher commented 8 years ago

A swig template misplaced, should be fixed now!