search

mbrukman / autogen

Automatically generate boilerplate license comments.
Apache License 2.0
98 stars 27 forks source link

JavaScript: Conflict with eslinst Google rules #16

Closed dandv closed 7 years ago

dandv commented 8 years ago

Running eslint produces the spaced-comment error:

Expected space or tab after '//' in comment spaced-comment

Here's the linting rule.

One workaround would be to change that rule to allow for a / exception:

"spaced-comment": ["error", "always", { "markers": ["/"] }]
addyosmani commented 8 years ago

One workaround would be to change that rule to allow for a / exception:

I would be in favor of this change. If there are recommendations/patches folks would like to propose for the eslint google ruleset, please feel free to comment on the issue Dan linked to above.

mbrukman commented 7 years ago

I'm going to fix this in autogen by making the line-of-comment-characters optional, which will also address another reported issue #12 so you don't need to change eslint on autogen's account.

mbrukman commented 7 years ago

I submitted a change that, in theory, should make the new output compliant with eslint. Please take a look and let me know if it's now OK and we can close this issue. Thanks for the feedback!

mbrukman commented 7 years ago

@dandv — assigning the issue to you to verify whether the change I made addresses your concerns.

mbrukman commented 7 years ago

Closing this issue as I believe it has been addressed with making the comment line optional (and off by default). If there are any other issues, please add a comment and reopen.