search

mbrukman / autogen

Automatically generate boilerplate license comments.
Apache License 2.0
98 stars 27 forks source link

Added ability to skip generating boilerplate code and runline #48

Closed gennadiycivil closed 7 years ago

gennadiycivil commented 7 years ago

New command line flag to fix #47

gennadiycivil commented 7 years ago

Please take a look at new changes. I just implemtented python for now. Also I added tests but in seemed crazy to add tests for all flag combinations so I added py-no-tls-no-run-line-no-code tests. if you OK these I will add other languages. Let me know.

gennadiycivil commented 7 years ago

I added changes for other languages, another unit test, and addressed your comments. Please take a look, should be close

gennadiycivil commented 7 years ago

PTAL

gennadiycivil commented 7 years ago

ptal

gennadiycivil commented 7 years ago

ping

gennadiycivil commented 7 years ago

Please take a look

gennadiycivil commented 7 years ago

ptal

mbrukman commented 7 years ago

I will squash and merge; the tests passed on Travis on Linux but have not even started on macOS, so skipping those.

mbrukman commented 7 years ago

@gennadiycivil — thank you for your contribution and for your patience with this review!

BTW, since you used your master branch, you won't be able to merge this cleanly; please consider deleting your fork on GitHub and creating a new fork. For future PRs, please create a new feature branch for every PR and keep the master simply for syncing with upstream (i.e., this repo).

gennadiycivil commented 7 years ago

@mbrukman thank you. I deleted my fork and re-created new one just in case.