search

mbruzek / layer-k8s

A repository for the Kubernetes charm implmeneted in the reactive framework.
9 stars 3 forks source link

working DNS status feature #14

Closed lazypower closed 8 years ago

lazypower commented 8 years ago

Still a candidate for refactoring, but this greenlights the deployment w/ SkyDNS powering local service discovery

lazypower commented 8 years ago

@mbruzek dont review this yet, its apparently got merge issues. I want to refactor this a bit and will rebase on top of master.

Monday AM should be sweet :)

mbruzek commented 8 years ago

Thanks for the comment. I pulled this up for review today, but will defer until I hear from you.

lazypower commented 8 years ago

@mbruzek - i rebased. this should be g2g - use a cautious eye to make sure i didn't override something critical. this passes deploy / validation tests here w/ the shipped guestbook action

juju action do k8s/0 guestbook-example will turn up the guestbook sample.

kubectl get svc curl 10.1.x.x

Should be g2g once all the pods are online. this takes ~ 15 seconds from request to completion.

mbruzek commented 8 years ago

+1 LGTM. The latest version of this code looks OK. One method not used but we can remove it or use it later.

lazypower commented 8 years ago

We can gut this method matt. I like your approach to recycling the services. I used this for a convenience call when devving and it made its way into this PR :(