search

mbsantiago / whombat

Audio Annotation Tool for ML development
https://mbsantiago.github.io/whombat/
GNU General Public License v3.0
33 stars 5 forks source link

Introduce smaller fixes #20

Closed adur1990 closed 4 months ago

adur1990 commented 5 months ago

During the deployment of whombat I noticed some problems.

  1. the were hard-coded hostnames in the frontend with are not required. I removed them.
  2. Second, we use whombat with the postgres backend. However, in the requirements were missing dependencies, as well as in the app.py imports. These are now included.
  3. I version-pinned all dependencies in the requirements and included matplotlib, as some packages whombat depends on got updates, some with breaking changes (e.g. matplotlib)
  4. Finally, there was a datetime bug in the base model preventing whombat working with postgres
codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 59.86%. Comparing base (97de568) to head (3d37319).

:exclamation: Current head 3d37319 differs from pull request most recent head f8a7c3f

Please upload reports for the commit f8a7c3f to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #20 +/- ## ======================================= Coverage 59.86% 59.86% ======================================= Files 171 171 Lines 7624 7624 ======================================= Hits 4564 4564 Misses 3060 3060 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

adur1990 commented 4 months ago

Ah dangit. Please ignore this PR. I forgot about the PR and pushed more commits on the same branch. I would like to split the huge PR into smaller, more logically organized PRs.