mbucc / shmig

Database migration tool written in BASH.
BSD 3-Clause "New" or "Revised" License
458 stars 49 forks source link

Reduce number of Docker layers #20

Closed PuKoren closed 7 years ago

PuKoren commented 7 years ago
mbucc commented 7 years ago

@synchrone Any comments? (@PuKoren I'm a docker noob, Synchrone is the one that started docker with shmig.)

mbucc commented 7 years ago

For my edification, from http://stackoverflow.com/a/33836848/1789168:

PuKoren commented 7 years ago

After a check on my PR, it seems that I have moved default folder for migration from /sql to /migrations, should I update the PR to rollback to /sql?

mbucc commented 7 years ago

Yes, that change would break others that rely on that default.

-----Original Message----- From: "Jonathan Muller" notifications@github.com Sent: ‎2/‎13/‎2017 11:18 To: "mbucc/shmig" shmig@noreply.github.com Cc: "mbucc" mkbucc@gmail.com; "Comment" comment@noreply.github.com Subject: Re: [mbucc/shmig] Reduce number of Docker layers (#20)

After a check on my PR, it seems that I have moved default folder for migration from /sql to /migrations, should I update the PR to rollback to /sql? — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

PuKoren commented 7 years ago

You are right, updated my commit and doc

PuKoren commented 7 years ago

Updated with review comments, thanks

synchrone commented 7 years ago

LGTM