Closed PuKoren closed 7 years ago
@synchrone Any comments? (@PuKoren I'm a docker noob, Synchrone is the one that started docker with shmig.)
For my edification, from http://stackoverflow.com/a/33836848/1789168:
After a check on my PR, it seems that I have moved default folder for migration from /sql
to /migrations
, should I update the PR to rollback to /sql
?
Yes, that change would break others that rely on that default.
-----Original Message----- From: "Jonathan Muller" notifications@github.com Sent: 2/13/2017 11:18 To: "mbucc/shmig" shmig@noreply.github.com Cc: "mbucc" mkbucc@gmail.com; "Comment" comment@noreply.github.com Subject: Re: [mbucc/shmig] Reduce number of Docker layers (#20)
After a check on my PR, it seems that I have moved default folder for migration from /sql to /migrations, should I update the PR to rollback to /sql? — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.
You are right, updated my commit and doc
Updated with review comments, thanks
LGTM