mbuesch / razer

Razer device library and tools
http://bues.ch/h/razercfg
GNU General Public License v2.0
253 stars 50 forks source link

freedesktop icon #63

Closed janstuemmel closed 8 years ago

janstuemmel commented 8 years ago

i made a simple svg icon for razercfg.

Issue: #59

z3ntu commented 8 years ago

I would leave a bit more space between each "circle of snake". Otherwise it looks pretty good! EDIT: So maybe less of the "circles" and the head a bit bigger.

mjtorn commented 8 years ago

+1 for this icon but also +1 for having more space, if it's not a huge hassle

mbuesch commented 8 years ago

I like version number 3 and 4. But I wonder whether we could make a connection to Linux somehow. (Nope, just pasting Tux somewhere in there is not an option. :) It probably also is a good idea to have multiple icons (just make an icons subdir) and have one "main one" for the desktop file or such.

janstuemmel commented 8 years ago

maybe using tux colors for the connection to linux see suggestion 5

janstuemmel commented 8 years ago

which do you like, please choose one. then i make one bare snake svg and one freedesktop icon. are you cool with the pr?

mjtorn commented 8 years ago

Does anyone know (or have time to look up) what the Freedesktop standard says about multiple icons? My only request with this, related to #58, would be that the default icon or whatever icon goes into a future Debian package is named razercfg-icon.png, but if that's a no-go for any reason I'm sure the name can be adapted elsewhere.

janstuemmel commented 8 years ago

if you look into /usr/share/icons/applications/hicolor/scalable/apps/ there are the icons for example 'libreoffice-draw' in svg, hicolor is the fallback theme for freedesktop distros. so we can put razercfg.svg in this dir and add in the .desktop file Icon=razercfg. no need for png files

mjtorn commented 8 years ago

I agree that 3 and 4 are the best ones.

Is Tux a requirement, ie. would this compile or run on a BSD? Having Tux there would also make the icon very crowded and in the case of 3 (my favorite) also look like he's going to get eaten :D

For the different coloring options, I'm sure anyone using this would expect a Razer-related program to have the Razer-green color in the icon at least somewhere.

mbuesch commented 8 years ago

Having Tux there

As I said, pasting tux somewhere in there is not an option.

janstuemmel commented 8 years ago

hi, maybe its time to know which icon you prefer, so i can finish this... :) i for the green or orange green

mbuesch commented 8 years ago

Ok, let's simply take #_4 as the main base for the new logo, the lower left from #_5 as a variation and #_3 as a completely different alternative.

z3ntu commented 8 years ago

I agree

mjtorn commented 8 years ago

@janstuemmel would you mind updating the desktop file stuff and debian/ distribution when you're done? Then the package wouldn't be in an inconsistent state.

Just update the razercfg.desktop.template file and add the icons to debian/qrazercfg.install - and uninstall.sh as well. That's off the top of my head, there might be something more, but I doubt it.

janstuemmel commented 8 years ago

ok ill do that. but maybe i will need a few days...

janstuemmel commented 8 years ago

i would choose the razercfg-snake.svg as tray icon. maybe its good if i upload the the pngs as well. the right icon location is the hicolor fallback theme:

mjtorn commented 8 years ago

It's been a while, so got to ask, is anything happening here?

mbuesch commented 8 years ago

I'm waiting for an updated pull request.

janstuemmel commented 8 years ago

ok i will finish this up, just say me what structure you would like...

mbuesch commented 8 years ago

structure?

janstuemmel commented 8 years ago

i mean, generate which extension out of the png, where to put them, or just leave the single svg in icons...

mbuesch commented 8 years ago

Ah OK. Well about the place to put this: Just make an icons subdir or such. And then just put the icons in there. I don't care that much about png. They can even be auto-generated on package install, if distributions care.

janstuemmel commented 8 years ago

are you ok now with that pr, should i do a rebase?

mbuesch commented 8 years ago

Yes, please rebase and remove all unnecessary commits (see git rebase --interactive)

janstuemmel commented 8 years ago

ok, need a few minutes