mbuesch / razer

Razer device library and tools
http://bues.ch/h/razercfg
GNU General Public License v2.0
251 stars 50 forks source link

new model of deathadder 3500 DPI RZ01-0163 #94

Closed h0rn3t closed 7 years ago

h0rn3t commented 7 years ago

added support new model of deathadder 3500 DPI model RZ01-0163

h0rn3t commented 7 years ago

seems working fine

mbuesch commented 7 years ago

Why do you create a new file? If the protocol is different from an existing one, please explain the differences.

mbuesch commented 7 years ago

"deathadder 3500" is not an acceptable name, because we already have that name in the hw_deathadder.c driver. Also: Do a pull request after you finished your work.

h0rn3t commented 7 years ago

@mbuesch okay

h0rn3t commented 7 years ago

@mbuesch some features of chroma version is not supported by 3500DPI version, "spectrum" mode for example

mbuesch commented 7 years ago

Thanks. I still prefer this to be in an existing driver, if the differences to the existing driver are not too big. There's a trade off between creating a new driver and adding conditionals to an existing one.

mbuesch commented 7 years ago

see the older hw_deathadder.c for an example. It supports several models that don't differ that much.

h0rn3t commented 7 years ago

@mbuesch okay thanks i'll check it