Initial POC for metric aggregations

mbuhot / eskotlin

Elasticsearch Query DSL for Kotlin

MIT License

136 stars 28 forks source link

Open CrAzE124 opened 5 years ago

CrAzE124 commented 5 years ago

Still a WIP - submitting for some guidance in terms of

module layout (aggregations.metrics)?
completeness (should each agg be feature complete - i.e. including "scripts" and related concepts?)

If this looks good I'll move on to the other metric aggs! Looking forward to assisting on this.

mbuhot commented 5 years ago

Looks pretty good to me 👍

For the package name, I’d prefer we either

1) use mbuhot.eskotlin.aggregation to match the existing aggregation builders

Or 2) move the filter / nested aggregation builders into a mbuhot.eskotlin.aggregations.bucket package .

@nzcoffeem what do you think?

As for completeness, feel free to implement as much functionality as you require for your own projects and document any limitations in the code.

Thanks!