mbusb / multibootusb

Create multiboot live Linux on a USB disk...
http://multibootusb.org/
GNU General Public License v2.0
1.39k stars 201 forks source link

Installing syslinux crashes with 9.1.0-1 (Linux Mint 18.3 host) #268

Closed Kassec closed 6 years ago

Kassec commented 6 years ago

Hello,

Trying to install syslinux to USB stick crashes :

$ sudo multibootusb
Running multibootusb version 9.1.0 from installed system...
Starting multibootusb GUI...
Cleaning old multibootusb directory...
Syslinux exist in multibootusb directory...
Using pyudev for detecting USB drives...
    /dev/sdc
    /dev/sdc1
Selected device /dev/sdc
USB disk is not mounted and can't update list widget...
Selected device /dev/sdc1
Installing default syslinux on /dev/sdc1
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/scripts/mbusb_gui.py", line 364, in onInstall_syslinuxClick
    ret = syslinux_default(config.usb_disk)
  File "/usr/lib/python3/dist-packages/scripts/syslinux.py", line 108, in syslinux_default
    mbr_install_cmd = 'dd bs=440 count=1 conv=notrunc if=' + mbr_bin + ' of=' + usb_disk[:-1]
TypeError: Can't convert 'bool' object to str implicitly
$ lsb_release -a
No LSB modules are available.
Distributor ID: LinuxMint
Description:    Linux Mint 18.3 Sylvia
Release:    18.3
Codename:   sylvia
shinji-s commented 6 years ago

Are you running mbusb in non-english locale? Then your issue is likely addressed by https://github.com/mbusb/multibootusb/commit/7657e7c70cb289bdce91199f2c069fe19944a493.

mbusb commented 6 years ago

I think the issue is addressed in the latest master. You may wantto check it out.

mbusb commented 6 years ago

@shinji-s , The non English local issue affect only Windows version. The bug reported here is a real issue.

shinji-s commented 6 years ago

@mbusb, Thank you for the heads up. I paid attention to the exception log part only. The cause may be the same: Failure to determine partition type of the target usb. After "Selected device /dev/sdc1" should not we see the detected partition type printed? Perhaps parted is not installed or not found in PATH? @Kassec, Can you see what happens if you do "sudo parted /dev/sdc print" or better yet try logging '_cmd_out' in gpt_device@scripts/usb.py?

shinji-s commented 6 years ago

Ah, parted is run against a partition (/dev/sdc1) rather than the entire disk (/dev/sdc). Is it reporting 'loop' as the partition type? Perhaps related with https://github.com/mbusb/multibootusb/issues/265. Evident on Fedora?

mbusb commented 6 years ago

The issue has been fixed in the devel and master branch. Should not occur in next release.

mbusb commented 6 years ago

Try latest release. Fixed it.